lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1332115559
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -115,25 +114,30 @@ public int memberEpoch() {
@Override
public void updateState(ConsumerGroupHeartbeatResponseData response) {
- if (response.errorCode() == Errors.NONE.code()) {
Review Comment:
I think we should validate here that the response contains no error (and
throw IllegalArgument if so), as this func now is only expected to be called on
successful responses. Without such validation, an erroneous call to this func
in the case of an error would end up going unnoticed and transition the member
to stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
