[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

[via GitHub]

lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1332041024


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time time,
                             logContext);
             CoordinatorRequestManager coordinatorRequestManager = null;
             CommitRequestManager commitRequestManager = null;
+            HeartbeatRequestManager heartbeatRequestManager = null;
+            MembershipManager membershipManaber = null;

Review Comment:
   This is only needed when there is a groupId defined so I would move it 
completely to the `if (groupState.groupId != null)` block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org