kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334892999
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##########
@@ -249,7 +250,9 @@ private <K, V> Record nextFetchedRecord(FetchConfig<K, V>
fetchConfig) {
* @param maxRecords The number of records to return; the number returned
may be {@code 0 <= maxRecords}
* @return {@link ConsumerRecord Consumer records}
*/
- <K, V> List<ConsumerRecord<K, V>> fetchRecords(FetchConfig<K, V>
fetchConfig, int maxRecords) {
+ <K, V> List<ConsumerRecord<K, V>> fetchRecords(FetchConfig fetchConfig,
+ Deserializers<K, V>
deserializers,
Review Comment:
Will do.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchConfig.java:
##########
@@ -54,11 +49,8 @@
*
* Note: the {@link Deserializer deserializers} used for the key and value are
not closed by this class. They should be
* closed by the creator of the {@link FetchConfig}.
- *
Review Comment:
Will exorcise them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
