kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334893631
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java:
##########
@@ -18,11 +18,18 @@
import
org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult;
+import java.io.Closeable;
+
/**
* {@code PollResult} consist of {@code UnsentRequest} if there are requests
to send; otherwise, return the time till
* the next poll event.
*/
-public interface RequestManager {
+public interface RequestManager extends Closeable {
Review Comment:
The `FetchRequestManager` does by virtue of extending from `AbstractFetch`.
The sole reason for that it is so that it can prepare to send requests to the
brokers to close their fetch sessions. It's kind of kludgey the way it's done,
so I'll take another look to see if it can be done more cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
