jolshan commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1336455099
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -449,6 +452,10 @@ class GroupMetadataManager(brokerId: Int,
| Errors.INVALID_FETCH_SIZE =>
Errors.INVALID_COMMIT_OFFSET_SIZE
+ case Errors.INVALID_PRODUCER_ID_MAPPING
+ | Errors.INVALID_TXN_STATE =>
+ Errors.UNKNOWN_MEMBER_ID
Review Comment:
Sorry I resolved the PR comment, but I had a discussion with myself here:
https://github.com/apache/kafka/pull/14370#discussion_r1322225993
Similar to the produce request, we wanted to have a non-fatal error here. (I
suppose there is an argument for the invalid PID mapping being fatal)
What do you think? There are only 2 abortable errors returned by this
request.
```
} else if (error == Errors.UNKNOWN_MEMBER_ID
|| error == Errors.ILLEGAL_GENERATION) {
abortableError(new CommitFailedException("Transaction
offset Commit failed " +
"due to consumer group metadata mismatch: " +
error.exception().getMessage()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
