[GitHub] [kafka] jolshan commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

[via GitHub]

jolshan commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1341806378


##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -449,6 +452,10 @@ class GroupMetadataManager(brokerId: Int,
                        | Errors.INVALID_FETCH_SIZE =>
                     Errors.INVALID_COMMIT_OFFSET_SIZE
 
+                  case Errors.INVALID_PRODUCER_ID_MAPPING
+                       | Errors.INVALID_TXN_STATE =>
+                    Errors.UNKNOWN_MEMBER_ID

Review Comment:
   For posterity, we decided to not go with the abortable error and stick with 
the fatal one since it makes it clearer what happened. We also can't guarantee 
clients treat unknown member as non-fatal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org