[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

[via GitHub]

iit2009060 commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1338498452


##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
       timeIndex.flush()
     }
   }
+
+  private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+    val pw =  new PrintWriter((remoteOffsetIndexFile(new 
File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))

Review Comment:
   Yes @divijvaidya I will do it from next time , but is there a way to open 
this file , it seems to be created in build server ?
   
"file:///home/jenkins/workspace/Kafka_kafka-pr_PR-14459/storage/build/reports/checkstyle/main.html"
   



##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
       timeIndex.flush()
     }
   }
+
+  private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+    val pw =  new PrintWriter((remoteOffsetIndexFile(new 
File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))

Review Comment:
   Yes @divijvaidya I will do it from next commit , but is there a way to open 
this file , it seems to be created in build server ?
   
"file:///home/jenkins/workspace/Kafka_kafka-pr_PR-14459/storage/build/reports/checkstyle/main.html"
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org