divijvaidya commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1339202068
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -310,7 +310,7 @@ private <T> T loadIndexFile(File file,
RemoteLogSegmentMetadata remoteLogSegment
if (Files.exists(indexFile.toPath())) {
try {
index = readIndex.apply(indexFile);
- } catch (CorruptRecordException ex) {
Review Comment:
> Was this not covered by a test in the initial PR
@Hangleton no we don't have a test case to execute this code. In fact, the
bug fixed this PR was discovered while working on the task [1] to add more unit
test for remote index cache.
[1] https://issues.apache.org/jira/browse/KAFKA-15169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
