jolshan commented on code in PR #14470: URL: https://github.com/apache/kafka/pull/14470#discussion_r1344419654
########## core/src/main/scala/kafka/server/ReplicaManager.scala: ########## @@ -766,7 +775,8 @@ class ReplicaManager(val config: KafkaConfig, } topicPartition -> LogAppendResult( LogAppendInfo.UNKNOWN_LOG_APPEND_INFO, - Some(finalException) + Some(finalException), + hasCustomErrorMessage = true Review Comment: Maybe this is ok -- but I think we are still returning custom error messages for non-custom messages in the final case of the match here. Error.exception I think uses the default message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org