splett2 commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1344456909
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -74,11 +74,20 @@ import scala.jdk.CollectionConverters._
/*
* Result metadata of a log append operation on the log
*/
-case class LogAppendResult(info: LogAppendInfo, exception: Option[Throwable] =
None) {
+case class LogAppendResult(info: LogAppendInfo,
+ exception: Option[Throwable],
+ hasCustomErrorMessage: Boolean) {
Review Comment:
honestly, I'm just not a fan of having default args. I think it makes things
less explicit, hence the change.
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -74,11 +74,20 @@ import scala.jdk.CollectionConverters._
/*
* Result metadata of a log append operation on the log
*/
-case class LogAppendResult(info: LogAppendInfo, exception: Option[Throwable] =
None) {
+case class LogAppendResult(info: LogAppendInfo,
+ exception: Option[Throwable],
+ hasCustomErrorMessage: Boolean) {
Review Comment:
honestly, I'm just not a fan of having default args. I think it makes things
tricky to reason about, hence the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
