cmccabe commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1344799188
########## generator/src/main/java/org/apache/kafka/message/FieldSpec.java: ########## @@ -157,11 +157,6 @@ private void checkTagInvariants() { this.taggedVersions + ", which is not open-ended. taggedVersions must " + "be either none, or an open-ended range (that ends with a plus sign)."); } - if (!this.taggedVersions.intersect(this.versions).equals(this.taggedVersions)) { - throw new RuntimeException("Field " + name + " specifies taggedVersions " + - this.taggedVersions + ", and versions " + this.versions + ". " + - "taggedVersions must be a subset of versions."); - } Review Comment: Tagged fields cannot be removed because reusing a tag would cause incompatibility. Eventually we should have a way of "burning" a tag, but we don't have it yet. So do not remove tagged fields for now. ########## generator/src/main/java/org/apache/kafka/message/FieldSpec.java: ########## @@ -157,11 +157,6 @@ private void checkTagInvariants() { this.taggedVersions + ", which is not open-ended. taggedVersions must " + "be either none, or an open-ended range (that ends with a plus sign)."); } - if (!this.taggedVersions.intersect(this.versions).equals(this.taggedVersions)) { - throw new RuntimeException("Field " + name + " specifies taggedVersions " + - this.taggedVersions + ", and versions " + this.versions + ". " + - "taggedVersions must be a subset of versions."); - } Review Comment: Tagged fields cannot be removed because reusing a tag ID would cause incompatibility. Eventually we should have a way of "burning" a tag, but we don't have it yet. So do not remove tagged fields for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org