rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1346091394
##########
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##########
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions + ", which is not open-ended.
taggedVersions must " +
"be either none, or an open-ended range (that ends with a
plus sign).");
}
- if
(!this.taggedVersions.intersect(this.versions).equals(this.taggedVersions)) {
- throw new RuntimeException("Field " + name + " specifies
taggedVersions " +
- this.taggedVersions + ", and versions " + this.versions +
". " +
- "taggedVersions must be a subset of versions.");
- }
Review Comment:
Yeah, I think that's correct, the .json file still contains the now-closed
tagged field and its tag. I wonder if that is good enough to "burn" that tag.
Seems like it should be, but I am not familiar enough with these details to
know. @cmccabe any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
