ijuma commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1345296313
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -96,10 +96,10 @@ final class KafkaMetadataLog private (
}
private def handleAndConvertLogAppendInfo(appendInfo:
internals.log.LogAppendInfo): LogAppendInfo = {
- if (appendInfo.firstOffset.isPresent())
- new LogAppendInfo(appendInfo.firstOffset.get().messageOffset,
appendInfo.lastOffset)
+ if (appendInfo.firstOffset != UnifiedLog.UnknownOffset)
Review Comment:
We are making things less type safe here by using sentinels vs types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
