dajac commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1746844528
> @dajac @lianetm Thanks for the feedback. I addressed more of your comments. I wanted to point out that I filed 3 follow-up tickets to close some of the gaps. These are: > > * Propagate time during failure to avoid time.milliseconds(): https://issues.apache.org/jira/browse/KAFKA-15534 > * Ensure some of the fields are only sent once: https://issues.apache.org/jira/browse/KAFKA-15533 > * Ensure coordinator node is removed on disconnection: https://issues.apache.org/jira/browse/KAFKA-15531 > > I believe all of the open comments are addressed/replied, so let me know if there's anything else. Thanks. We also need to handle the consumer close case and send the final heartbeat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
