philipnee commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1747674288
Thanks @dajac - I refactored some tests based on your comments. Thanks a lot for putting time into it. Here I've got a list of Jira for the follow-ups: - Propagate time during failure to avoid time.milliseconds(): https://issues.apache.org/jira/browse/KAFKA-15534 - Ensure some of the fields are only sent once: https://issues.apache.org/jira/browse/KAFKA-15533 - Ensure coordinator node is removed on disconnection: https://issues.apache.org/jira/browse/KAFKA-15531 - Send Heartbeat on closing the consumer as part of handling close(): https://issues.apache.org/jira/browse/KAFKA-15548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org