cadonna opened a new pull request, #14508: URL: https://github.com/apache/kafka/pull/14508
When tasks are found corrupted, Kafka Streams tries to commit the non-corrupted tasks before closing and reviving the corrupted active tasks. Besides active running tasks, Kafka Streams tries to commit restoring active tasks and standby tasks. However, restoring active tasks do not need to be committed since they do not have offsets to commit and the current code does not write a checkpoint. Furthermore, trying to commit restoring active tasks with the state updater enabled results in the following error: java.lang.UnsupportedOperationException: This task is read-only at org.apache.kafka.streams.processor.internals.ReadOnlyTask.commitNeeded(ReadOnlyTask.java:209) ... since commitNeeded() is not a read-only method for active tasks. In future, we can consider writing a checkpoint for active restoring tasks in this situation. Additionally, we should fix commitNeeded() in active tasks to be read-only. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
