mjsax commented on code in PR #14508:
URL: https://github.com/apache/kafka/pull/14508#discussion_r1349252619
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -223,10 +223,7 @@ boolean handleCorruption(final Set<TaskId> corruptedTasks)
{
final Collection<Task> tasksToCommit = allTasks()
.values()
.stream()
- // TODO: once we remove state restoration from the stream
thread, we can also remove
- // the RESTORING state here, since there will not be any
restoring tasks managed
- // by the stream thread anymore.
- .filter(t -> t.state() == Task.State.RUNNING || t.state() ==
Task.State.RESTORING)
+ .filter(t -> t.state() == Task.State.RUNNING)
Review Comment:
Given that we still have a feature flag, should we make this condition more
complex and consider if the state updater thread is enabled or not, and check
different conditions for both cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
