jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1357181404


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
 
     public short fetchRequestVersion() {
         if (this.isAtLeast(IBP_3_5_IV1)) {
-            return 15;
+            return 16;

Review Comment:
   Clusters with ibp 3.5 were guaranteed to support version 15 since that was 
the version we defined the ibp. I don't think we can just change the version 
because some clusters will have ibp 3.5, but not version 16 fetch requests. We 
could avoid this with the tagged fields, but since we are bumping the version, 
we run into a problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to