chb2ab commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1357293893
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() { public short fetchRequestVersion() { if (this.isAtLeast(IBP_3_5_IV1)) { - return 15; + return 16; Review Comment: I remember why I added this now, we have a test that checks we're using the latest version for various API's. I guess we would need to remove that for FETCH. https://github.com/apache/kafka/blob/13b2edd9af802d7db99815e834b062aafc3e2313/core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala#L120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org