jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1360994577
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
public short fetchRequestVersion() {
if (this.isAtLeast(IBP_3_5_IV1)) {
- return 15;
+ return 16;
Review Comment:
I chatted with David J about this offline. Since we are using MV/IBP bumps
for fetches, a simple thing to do would be to pick up the newest MV for this
release and include the fetch bump here.
The alternative is setting up the fetch path to use ApiVersions to ensure
the correct version. But that might be out of scope for this change.
With either of these approaches we can keep the latest version for the
replication fetches which would make things a little clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
