chb2ab commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1361154283
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
public short fetchRequestVersion() {
if (this.isAtLeast(IBP_3_5_IV1)) {
- return 15;
+ return 16;
Review Comment:
> Since we are using MV/IBP bumps for fetches, a simple thing to do would be
to pick up the newest MV for this release and include the fetch bump here
ok, so my understanding is instead of bumping IBP to `IBP_3_7_IV1` we would
wait for the release of 'IBP_3_8_IV0' to bump the fetch version here to 16.
> The alternative is setting up the fetch path to use ApiVersions to ensure
the correct version. But that might be out of scope for this change.
yeah, I would need to look more into this, I'm not familiar enough to know
how it might look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
