lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362149712
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -68,14 +107,16 @@ public MembershipManagerImpl(String groupId, String
groupInstanceId, AssignorSel
}
this.groupInstanceId = Optional.ofNullable(groupInstanceId);
this.targetAssignment = Optional.empty();
- this.nextTargetAssignment = Optional.empty();
+ this.log = logContext.logger(MembershipManagerImpl.class);
}
/**
* Update assignor selection for the member.
*
- * @param assignorSelection New assignor selection
- * @throws IllegalArgumentException If the provided assignor selection is
null
+ * @param assignorSelection New assignor selection. If empty is provided,
this will
+ * effectively clear the previous assignor
selection defined for the
+ * member.
+ * @throws IllegalArgumentException If the provided optional assignor
selection is null.
*/
public final void setAssignorSelection(AssignorSelection
assignorSelection) {
Review Comment:
Good point, this is only defined when the consumer is created. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
