apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362679708
##########
clients/src/test/java/org/apache/kafka/common/protocol/ProtoUtilsTest.java:
##########
@@ -34,6 +34,7 @@ public void testDelayedAllocationSchemaDetection() {
case EXPIRE_DELEGATION_TOKEN:
case RENEW_DELEGATION_TOKEN:
case ALTER_USER_SCRAM_CREDENTIALS:
+ case PUSH_TELEMETRY:
Review Comment:
So it depends on whether request is marked `Forwardable` or not i.e. can be
wrapped in envelope to forward. In our case the APIs are not forwardable as not
required to be sent to other brokers. But the requests which are not
forwardable goes through additional check if they have buffer reference which
in this case only PUSH_TELEMETRY has
```
Schema.Visitor detector = new Schema.Visitor() {
@Override
public void visit(Type field) {
if (field == BYTES || field == NULLABLE_BYTES || field ==
RECORDS ||
field == COMPACT_BYTES || field ==
COMPACT_NULLABLE_BYTES)
hasBuffer.set(true);
}
};
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
