kirktrue commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1364309258
########## clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, + "type": "response", + "name": "GetTelemetrySubscriptionsResponse", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { + "name": "ThrottleTimeMs", "type": "int32", "versions": "0+", + "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." + }, + { + "name": "ErrorCode", "type": "int16", "versions": "0+", + "about": "The error code, or 0 if there was no error." + }, + { + "name": "ClientInstanceId", "type": "uuid", "versions": "0+", + "about": "Assigned client instance id if ClientInstanceId was 0 in the request, else 0." + }, + { + "name": "SubscriptionId", "type": "int32", "versions": "0+", + "about": "Unique identifier for the current subscription set for this client instance." + }, + { + "name": "AcceptedCompressionTypes", "type": "[]int8", "versions": "0+", + "about": "Compression types that broker accepts for the PushTelemetryRequest." + }, + { + "name": "PushIntervalMs", "type": "int32", "versions": "0+", + "about": "Configured push interval, which is the lowest configured interval in the current subscription set." + }, + { + "name": "TelemetryMaxBytes", "type": "int32", "versions": "0+", + "about": "The maximum bytes of binary data the broker accepts in PushTelemetryRequest." Review Comment: I can only assume this maximum is post-compression, right? ########## clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, + "type": "request", + "listeners": ["broker"], + "name": "GetTelemetrySubscriptionsRequest", + "validVersions": "0", + "flexibleVersions": "0+", + // The Telemetry APIs are added as part of KIP-714 and are still under + // development. Hence, the APIs are not exposed by default unless explicitly + // enabled. + "latestVersionUnstable": true, + "fields": [ + { + "name": "ClientInstanceId", "type": "uuid", "versions": "0+", Review Comment: Is it possible to make the `GetTelemetrySubscriptionsRequest`'s `ClientInstanceId` optional vs. setting it to `0`? Just a preference thing, ignore if you want 😉 ########## clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, + "type": "response", + "name": "GetTelemetrySubscriptionsResponse", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { + "name": "ThrottleTimeMs", "type": "int32", "versions": "0+", + "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." + }, + { + "name": "ErrorCode", "type": "int16", "versions": "0+", + "about": "The error code, or 0 if there was no error." + }, + { + "name": "ClientInstanceId", "type": "uuid", "versions": "0+", + "about": "Assigned client instance id if ClientInstanceId was 0 in the request, else 0." + }, + { + "name": "SubscriptionId", "type": "int32", "versions": "0+", + "about": "Unique identifier for the current subscription set for this client instance." + }, + { + "name": "AcceptedCompressionTypes", "type": "[]int8", "versions": "0+", + "about": "Compression types that broker accepts for the PushTelemetryRequest." Review Comment: I forget: where is the mapping from these integer IDs to the algorithms? ########## clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, + "type": "request", + "listeners": ["broker"], + "name": "GetTelemetrySubscriptionsRequest", + "validVersions": "0", + "flexibleVersions": "0+", + // The Telemetry APIs are added as part of KIP-714 and are still under + // development. Hence, the APIs are not exposed by default unless explicitly + // enabled. + "latestVersionUnstable": true, + "fields": [ + { + "name": "ClientInstanceId", "type": "uuid", "versions": "0+", Review Comment: Is it possible to make the `GetTelemetrySubscriptionsRequest`'s `ClientInstanceId` optional vs. setting it to `0`? Just a preference thing, ignore if you want 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
