jlprat commented on code in PR #14572:
URL: https://github.com/apache/kafka/pull/14572#discussion_r1363669588
##########
server-common/src/main/java/org/apache/kafka/timeline/BaseHashTable.java:
##########
@@ -224,15 +224,15 @@ static int findSlot(Object object, int numElements) {
*/
static <T> void unpackSlot(List<T> out, Object[] elements, int slot) {
Object value = elements[slot];
- if (value == null) {
- return;
Review Comment:
This is done to avoid a return on a void method
##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -201,7 +201,7 @@ private void remove(EventContext eventContext) {
}
}
- private void handleEvents() throws InterruptedException {
Review Comment:
No call in the method throws `InterruptedException`
##########
server-common/src/main/java/org/apache/kafka/timeline/BaseHashTable.java:
##########
@@ -180,7 +180,7 @@ final T baseRemove(Object key) {
/**
* Expand the hash table to a new size. Existing elements will be copied
to new slots.
*/
- final private void rehash(int newSize) {
Review Comment:
This is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
