mimaison commented on code in PR #14572:
URL: https://github.com/apache/kafka/pull/14572#discussion_r1366957220
##########
server-common/src/main/java/org/apache/kafka/server/util/json/JsonValue.java:
##########
@@ -26,18 +26,16 @@
/**
* A simple wrapper over Jackson's JsonNode that enables type safe parsing via
the `DecodeJson` type
* class.
- *
+ * <br>
* Typical usage would be something like:
- *
- * {{{
+ * <pre><code>
Review Comment:
It looks like we forgot to update the code example when we converted this
class to Java, the snippet below is still in Scala.
##########
server-common/src/main/java/org/apache/kafka/server/util/timer/Timer.java:
##########
@@ -27,7 +27,7 @@ public interface Timer extends AutoCloseable {
/**
* Advance the internal clock, executing any tasks whose expiration has
been
* reached within the duration of the passed timeout.
- * @param timeoutMs
+ * @param timeoutMs the tme to advance in milliseconds
Review Comment:
`tme` -> `time`
##########
server-common/src/main/java/org/apache/kafka/server/util/ThroughputThrottler.java:
##########
@@ -64,7 +64,7 @@ public ThroughputThrottler(long targetThroughput, long
startMs) {
* @param amountSoFar bytes produced so far if you want to throttle data
throughput, or
* messages produced so far if you want to throttle
message throughput.
* @param sendStartMs timestamp of the most recently sent message
- * @return
+ * @return <code>true</code> if throttling happened
Review Comment:
Should it be `<code>true</code> if throttling should happen`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
