ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363844237
########## core/src/main/scala/kafka/log/UnifiedLog.scala: ########## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toList, None) } - private def batchMissingRequiredVerification(batch: MutableRecordBatch, requestVerificationGuard: Object): Boolean = { + private def batchMissingRequiredVerification(batch: MutableRecordBatch, requestVerificationGuard: VerificationGuard): Boolean = { producerStateManager.producerStateManagerConfig().transactionVerificationEnabled() && !batch.isControlBatch && - (requestVerificationGuard != verificationGuard(batch.producerId) || requestVerificationGuard == null) + (requestVerificationGuard == null || !requestVerificationGuard.equals(verificationGuard(batch.producerId))) Review Comment: Both implementations are correct. Personally I'd go with Justine's approach since the guard implements equals/hash code/toString. Static code checkers and humans would typically be surprised at reference quality being used in such cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org