ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364117639
########## core/src/main/scala/kafka/log/UnifiedLog.scala: ########## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toList, None) } - private def batchMissingRequiredVerification(batch: MutableRecordBatch, requestVerificationGuard: Object): Boolean = { + private def batchMissingRequiredVerification(batch: MutableRecordBatch, requestVerificationGuard: VerificationGuard): Boolean = { producerStateManager.producerStateManagerConfig().transactionVerificationEnabled() && !batch.isControlBatch && - (requestVerificationGuard != verificationGuard(batch.producerId) || requestVerificationGuard == null) + (requestVerificationGuard == null || !requestVerificationGuard.equals(verificationGuard(batch.producerId))) Review Comment: The sentinel could be value==0. I think that would be a lot cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org