kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364715414
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##########
@@ -162,7 +165,9 @@ private Fetch<K, V> fetchRecords(final CompletedFetch
nextInLineFetch) {
throw new IllegalStateException("Missing position for
fetchable partition " + tp);
if (nextInLineFetch.nextFetchOffset() == position.offset) {
- List<ConsumerRecord<K, V>> partRecords =
nextInLineFetch.fetchRecords(fetchConfig, fetchConfig.maxPollRecords);
+ List<ConsumerRecord<K, V>> partRecords =
nextInLineFetch.fetchRecords(fetchConfig,
Review Comment:
I've added this to KAFKA-15640 for a dedicate effort to clean up the
modifications to this data to make them atomic operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
