kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367508455
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##########
@@ -872,19 +876,16 @@ public byte[] deserialize(String topic, byte[] data) {
assignFromUser(singleton(tp0));
subscriptions.seek(tp0, 1);
- client.prepareResponse(matchesOffset(tidp0, 1),
fullFetchResponse(tidp0, this.records, Errors.NONE, 100L, 0));
+ client.prepareResponse(matchesOffset(tidp0, 1),
fullFetchResponse(tidp0, records, Errors.NONE, 100L, 0));
assertEquals(1, sendFetches());
consumerClient.poll(time.timer(0));
- // The fetcher should block on Deserialization error
+
for (int i = 0; i < 2; i++) {
- try {
- fetcher.collectFetch();
- fail("fetchedRecords should have raised");
- } catch (SerializationException e) {
- // the position should not advance since no data has been
returned
- assertEquals(1, subscriptions.position(tp0).offset);
- }
+ // The fetcher should block on Deserialization error
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
