jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1365957228
##########
clients/src/main/resources/common/message/ProduceResponse.json:
##########
@@ -59,10 +61,26 @@
"about": "The error message of the record that caused the batch to
be dropped"}
]},
{ "name": "ErrorMessage", "type": "string", "default": "null",
"versions": "8+", "nullableVersions": "8+", "ignorable": true,
- "about": "The global error message summarizing the common root
cause of the records that caused the batch to be dropped"}
+ "about": "The global error message summarizing the common root
cause of the records that caused the batch to be dropped"},
+ { "name": "CurrentLeader", "type": "LeaderIdAndEpoch", "versions":
"10+", "taggedVersions": "10+", "tag": 0, "fields": [
+ { "name": "LeaderId", "type": "int32", "versions": "10+", "default":
"-1", "entityType": "brokerId",
+ "about": "The ID of the current leader or -1 if the leader is
unknown."},
+ { "name": "LeaderEpoch", "type": "int32", "versions": "10+",
"default": "-1", "about": "The latest known leader epoch"}
+ ]}
]}
]},
{ "name": "ThrottleTimeMs", "type": "int32", "versions": "1+",
"ignorable": true, "default": "0",
- "about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." }
+ "about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
+ { "name": "NodeEndpoints", "type": "[]NodeEndpoint", "versions": "10+",
"taggedVersions": "10+", "tag": 0,
Review Comment:
Should we be using the same tag as the CurrentLeader field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
