jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1365955504
##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##########
@@ -156,7 +182,11 @@ public PartitionResponse(Errors error, long baseOffset,
long logAppendTime, long
}
public PartitionResponse(Errors error, long baseOffset, long
logAppendTime, long logStartOffset, List<RecordError> recordErrors, String
errorMessage) {
- this(error, baseOffset, INVALID_OFFSET, logAppendTime,
logStartOffset, recordErrors, errorMessage);
+ this(error, baseOffset, INVALID_OFFSET, logAppendTime,
logStartOffset, recordErrors, errorMessage, new
ProduceResponseData.LeaderIdAndEpoch());
+ }
+
+ public PartitionResponse(Errors error, long baseOffset, long
lastOffset, long logAppendTime, long logStartOffset, List<RecordError>
recordErrors, String errorMessage) {
+ this(error, baseOffset, lastOffset, logAppendTime, logStartOffset,
recordErrors, errorMessage, new ProduceResponseData.LeaderIdAndEpoch());
Review Comment:
Or even better, can we just leave empty and use a default? Or does that
bloat the constructors more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
