jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365978462
########## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import java.util.concurrent.atomic.AtomicLong; + +public class VerificationGuard { + + // The sentinel VerificationGuard will be used as a default when no verification guard is provided. + // It can not be used to verify a transaction is ongoing and its value is always 0. + public static final VerificationGuard SENTINEL = new VerificationGuard(0); + private static final AtomicLong INCREMENTING_ID = new AtomicLong(0L); + private final long value; + + public VerificationGuard() { + value = INCREMENTING_ID.incrementAndGet(); + } + + private VerificationGuard(long value) { + this.value = value; + } + + @Override + public String toString() { + return "VerificationGuard: " + value; + } + + @Override + public boolean equals(Object obj) { + if ((null == obj) || (obj.getClass() != this.getClass())) + return false; + VerificationGuard guard = (VerificationGuard) obj; + return value == guard.value(); + } + + @Override + public int hashCode() { + return Long.hashCode(value); + } + + private long value() { + return value; + } + + public boolean verifiedBy(VerificationGuard verifyingGuard) { Review Comment: Map and filter return types that are clearer to me, but maybe I'm just more familiar. I guess when you verify something the output is either "yes this was verified or no it is not". So I can see how you could get a boolean there. I could also see verification as an action that is silent and throws an error if it failed. Maybe I'm just being too grammatically minded here. I would say "x verifies y" and not "x verify y". For map and filter I see it as "map x to z using y" and "filter x to z using y" where x is the instance, y is the argument, and z is the output. For verify it would read as "Verify x using y." It's not a huge deal though so I can just change to verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
