ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364857293
########## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import java.util.concurrent.atomic.AtomicLong; + +public class VerificationGuard { + + // The sentinel VerificationGuard will be used as a default when no verification guard is provided. + // It can not be used to verify a transaction is ongoing and its value is always 0. + public static final VerificationGuard SENTINEL = new VerificationGuard(0); + private static final AtomicLong INCREMENTING_ID = new AtomicLong(0L); + private final long value; + + public VerificationGuard() { + value = INCREMENTING_ID.incrementAndGet(); + } + + private VerificationGuard(long value) { + this.value = value; + } + + @Override + public String toString() { + return "VerificationGuard: " + value; + } + + @Override + public boolean equals(Object obj) { + if ((null == obj) || (obj.getClass() != this.getClass())) + return false; + VerificationGuard guard = (VerificationGuard) obj; + return value == guard.value(); + } + + @Override + public int hashCode() { + return Long.hashCode(value); + } + + private long value() { + return value; + } + + public boolean verifiedBy(VerificationGuard verifyingGuard) { Review Comment: Nit: would `verify` be a better method name? It's the active voice which is generally better for methods. ########## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import java.util.concurrent.atomic.AtomicLong; + +public class VerificationGuard { Review Comment: Nit: should this be final? ########## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import java.util.concurrent.atomic.AtomicLong; + +public class VerificationGuard { + + // The sentinel VerificationGuard will be used as a default when no verification guard is provided. + // It can not be used to verify a transaction is ongoing and its value is always 0. + public static final VerificationGuard SENTINEL = new VerificationGuard(0); + private static final AtomicLong INCREMENTING_ID = new AtomicLong(0L); + private final long value; + + public VerificationGuard() { + value = INCREMENTING_ID.incrementAndGet(); + } + + private VerificationGuard(long value) { + this.value = value; + } + + @Override + public String toString() { + return "VerificationGuard: " + value; Review Comment: Nit: I think `VerificationGuard(2)` or `VerificationGuard(value=2)` (if value is 2) might be a more idiomatic way of implementing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
