kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367517181
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -188,7 +194,14 @@ public CompletableFuture<Map<TopicPartition,
OffsetAndTimestamp>> fetchOffsets(
* this function (ex. {@link
org.apache.kafka.common.errors.TopicAuthorizationException})
*/
public void resetPositionsIfNeeded() {
- Map<TopicPartition, Long> offsetResetTimestamps =
offsetFetcherUtils.getOffsetResetTimestamp();
+ Map<TopicPartition, Long> offsetResetTimestamps;
+
+ try {
+ offsetResetTimestamps =
offsetFetcherUtils.getOffsetResetTimestamp();
Review Comment:
There is a default offset reset strategy which is configured via
`ConsumerConfig`, passed to the `KafkaConsumer`, and then to the
`SubscriptionState`, right? Why wouldn't we fall back to that if there's no
overridden offset reset strategy for a particular partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
