chb2ab commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373238109
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_5_IV1)) {
+ if (this.isAtLeast(IBP_3_7_IV0)) {
Review Comment:
This is supposed to be the first approach mentioned in this comment
https://github.com/apache/kafka/pull/14444#discussion_r1360994577
My understanding is clusters would first be upgraded to 3.7 and then the IBP
would be bumped after all the brokers are upgraded, but please correct me if
that's wrong. You're right though, all the fields are tagged and there's no
change in handling on the broker side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
