jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373527381
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -102,6 +104,15 @@
"about": "The preferred read replica for the consumer to use on its
next fetch request"},
{ "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
]}
+ ]},
+ { "name": "NodeEndpoints", "type": "[]NodeEndpoint", "versions": "16+",
"taggedVersions": "16+", "tag": 0,
Review Comment:
> it looks like tags are scoped to the list level so this isn't really the
same tag. They also need to be contiguous within their scope so this gives an
error if I try to tag NodeEndpoints to something other than 0
Sharing the comment here for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
