apoorvmittal10 commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1374381174
##########
build.gradle:
##########
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+ if (!shouldPublishWithShadow) {
+ from components.java
+ } else {
+ apply plugin: 'com.github.johnrengelman.shadow'
Review Comment:
Valid ask, we require this plugin to move Opentelemetry required libs as
shadowed to avoid version conflicts when higher version of these commonly used
libraries are present in user's application code, but this
[link](https://imperceptiblethoughts.com/shadow/introduction/) for the plugin
details better. This dependency is not introduced in this PR rather being
already used in Kafka for a while:
https://github.com/apache/kafka/blob/f0e97397c01241be9d8d05b1642352b58d1ed196/build.gradle#L47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
