sanjay-awatramani commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1377536950
########## docker/jvm/jsa_launch: ########## @@ -0,0 +1,15 @@ +#!/usr/bin/env bash + +KAFKA_CLUSTER_ID="$(opt/kafka/bin/kafka-storage.sh random-uuid)" +opt/kafka/bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c opt/kafka/config/kraft/server.properties +KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=kafka.jsa" opt/kafka/bin/kafka-server-start.sh opt/kafka/config/kraft/server.properties & +PIDS=$! + +sleep 10 Review Comment: `sleep` is not the best way to wait for an application to be ready. We could check for something that indicates the app is ready (for e.g. checking if 9092 is ready to accept connections) and then maybe sleep a few seconds if required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
