sanjay-awatramani commented on code in PR #14552: URL: https://github.com/apache/kafka/pull/14552#discussion_r1377535456
########## docker/jvm/jsa_launch: ########## @@ -0,0 +1,15 @@ +#!/usr/bin/env bash + +KAFKA_CLUSTER_ID="$(opt/kafka/bin/kafka-storage.sh random-uuid)" +opt/kafka/bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c opt/kafka/config/kraft/server.properties +KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=kafka.jsa" opt/kafka/bin/kafka-server-start.sh opt/kafka/config/kraft/server.properties & +PIDS=$! + +sleep 10 +echo "test" | opt/kafka/bin/kafka-console-producer.sh --topic test-topic --bootstrap-server localhost:9092 Review Comment: - If there is an error at any step while creating JSA (e.g. unable to produce/consume) the JSA would have less than optimal information. We should bubble up the failure by failing the build so that this is identified rather than being suppressed. - I get a WARN that test-topic doesn't exist which seems that something has gone wrong in the build. Kafka automatically creates a topic so this warning can be ignored, but would be good to create a topic before producing to it so that we don't get unnecessary WARNings in the build output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
