kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378276022
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java:
##########
@@ -211,4 +226,17 @@ else if (t instanceof KafkaException)
throw new TimeoutException(e);
}
}
+
+ public static boolean maybeOverrideEnableAutoCommit(ConsumerConfig config)
{
+ Optional<String> groupId =
Optional.ofNullable(config.getString(CommonClientConfigs.GROUP_ID_CONFIG));
+ boolean enableAutoCommit =
config.getBoolean(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG);
+ if (!groupId.isPresent()) { // overwrite in case of default group id
where the config is not explicitly provided
Review Comment:
I didn't add it in this PR, no. The Jira refers to doing that in the "next
major release," so that would imply we should hold off and handle it outside
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
