philipnee commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1379033013
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -278,22 +283,22 @@ public PrototypeAsyncConsumer(final Time time,
}
}
- public PrototypeAsyncConsumer(LogContext logContext,
- String clientId,
- Deserializers<K, V> deserializers,
- FetchBuffer fetchBuffer,
- FetchCollector<K, V> fetchCollector,
- ConsumerInterceptors<K, V> interceptors,
- Time time,
- ApplicationEventHandler
applicationEventHandler,
- BlockingQueue<BackgroundEvent>
backgroundEventQueue,
- Metrics metrics,
- SubscriptionState subscriptions,
- ConsumerMetadata metadata,
- long retryBackoffMs,
- int defaultApiTimeoutMs,
- List<ConsumerPartitionAssignor> assignors,
- String groupId) {
+ public AsyncKafkaConsumer(LogContext logContext,
Review Comment:
I don't remember if this constructor is used for testing, if it is can we
change the scope to package-private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
