philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378452443
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer<K, V> implements
Consumer<K, V> {
private AtomicBoolean fencedInstance = new AtomicBoolean(false);
private final Optional<String> groupInstanceId;
+ private ExecutorService callbackExecutor =
Executors.newSingleThreadExecutor();
Review Comment:
Sorry - this is wrong. The way I wanted to do it in this PR is to register
the callbacks, when the future is completed, to the application thread. And we
invoke them when we call poll. I believe the callback invocation is currently
invoked on consumer.poll(), because this is where network clients are polled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
