philipnee commented on PR #14680: URL: https://github.com/apache/kafka/pull/14680#issuecomment-1791913330
Hi @dajac @kirktrue - Thanks for offering valuable feedbacks to this PR, much appreciated. I wonder how do you feel about using a local queue to stash the new callbacks? The goal really is to ensure these callbacks can be invoked on commit, poll, and close calls. Previously, David suggested that we could try to use the background queue; however, this is not really a feasible solution because we don't want the consumer to poll the queue during a commit (which could spit out a bunch of errors and rebalance events). I don't have a clean way of doing this unless we make a KIP change to enforce callbacks only invoked on poll. This is idea, but probably out of the scope. Any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
