kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1380662469
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -108,13 +106,19 @@
import static org.apache.kafka.common.utils.Utils.propsToMap;
/**
- * This prototype consumer uses an {@link ApplicationEventHandler event
handler} to process
- * {@link ApplicationEvent application events} so that the network IO can be
processed in a dedicated
+ * This {@link Consumer} implementation uses an {@link ApplicationEventHandler
event handler} to process
+ * {@link ApplicationEvent application events} so that the network I/O can be
processed in a dedicated
* {@link ConsumerNetworkThread network thread}. Visit
* <a
href="https://cwiki.apache.org/confluence/display/KAFKA/Proposal%3A+Consumer+Threading+Model+Refactor";>this
document</a>
- * for detail implementation.
+ * for implementation detail.
+ *
+ * <p/>
+ *
+ * <em>Note:</em> this {@link Consumer} implementation is part of the revised
consumer group protocol from KIP-848.
+ * This class should not be invoked directly; users should instead create a
{@link KafkaConsumer} as before.
+ * This consumer implements the new consumer group protocol and is intended to
be the default in coming releases.
*/
-public class PrototypeAsyncConsumer<K, V> implements Consumer<K, V> {
+public class AsyncKafkaConsumer<K, V> implements Consumer<K, V> {
Review Comment:
Done.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -148,30 +152,38 @@ public class PrototypeAsyncConsumer<K, V> implements
Consumer<K, V> {
private boolean cachedSubscriptionHasAllFetchPositions;
private final WakeupTrigger wakeupTrigger = new WakeupTrigger();
- public PrototypeAsyncConsumer(final Properties properties,
- final Deserializer<K> keyDeserializer,
- final Deserializer<V> valueDeserializer) {
+ public AsyncKafkaConsumer(Map<String, Object> configs) {
Review Comment:
Yep-done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
