dajac commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1389220863
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java:
##########
@@ -96,7 +96,7 @@ public NetworkClientDelegate.PollResult poll(final long
currentTimeMs) {
* @param topic to be requested. If empty, return the metadata for all
topics.
* @return the future of the metadata request.
*/
- public CompletableFuture<Map<String, List<PartitionInfo>>>
requestTopicMetadata(final Optional<String> topic) {
+ public CompletableFuture<Map<Topic, List<PartitionInfo>>>
requestTopicMetadata(final Optional<String> topic) {
Review Comment:
Do we still need the changes in this class? It seems that we don't use them
anymore. I have the same question for the new `Topic` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
