lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1392732597
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -1093,6 +1099,10 @@ private void subscribeInternal(Collection<String>
topics, Optional<ConsumerRebal
log.info("Subscribed to topic(s): {}", join(topics, ", "));
if (subscriptions.subscribe(new HashSet<>(topics), listener))
metadata.requestUpdateForNewTopics();
+
+ // Trigger subscribe event to effectively join the group if not
already part of it,
+ // or just send the new subscription to the broker.
+ applicationEventHandler.add(new
SubscriptionChangeApplicationEvent());
Review Comment:
I see, I was just intentionally leaving out all the pattern based logic
because we don't support it at this point. But this makes me realize that that
`subscribeInternal` based on pattern that you mentioned is wired to the
`subscribe(Pattern pattern)` API call, when it's truly not supported yet. I
think we should disable all the subscribe based on patterns until we implement
them properly. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
