ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391818555
########## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor; + +import org.apache.kafka.common.TopicPartition; + +public interface StandbyUpdateListener { + + enum SuspendReason { + MIGRATED, + PROMOTED + } + + /** + * Method called upon the creation of the Standby Task. Review Comment: ```suggestion * Method called upon the initialization of the standby task, just before it begins to load from the changelog. ``` nit: I won't comment this everywhere, and frankly it's not a big deal and I'm only pointing it out because it should be a quick fix with find&replace, but we usually don't capitalize terms like "Standby Task". Mainly to help differentiate between the common name and the class name. So for example "TopicPartition" is fine, but "Topic Partition" would be weird. Similarly, I would use "standby task" here, although "StandbyTask" is also correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
