ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1391891296
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -70,6 +71,7 @@
import static
org.apache.kafka.streams.internals.StreamsConfigUtils.ProcessingMode.EXACTLY_ONCE_V2;
import static
org.apache.kafka.streams.processor.internals.StateManagerUtil.parseTaskDirectoryName;
+@SuppressWarnings("ClassFanOutComplexity")
Review Comment:
Well actually after reading through the whole PR, I do think it's
unnecessary complexity for the `TaskManager` after all -- see [this
comment](https://github.com/apache/kafka/pull/14735#discussion_r1391855192).
But that's more because of the complexity of determining when to invoke
`#onUpdateSuspended` and to keep everything in the StoreChangelogReader class.
Hopefully that all makes sense to you too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
