lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1395130865
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -137,39 +135,104 @@ public HeartbeatRequestManager(
}
/**
- * Determines the maximum wait time until the next poll based on the
member's state, and creates a heartbeat
- * request.
+ * This will ensure that the member starts sending heartbeats to join the
group with the
+ * updated subscription, if it is not already part of it. If the member is
already part of
+ * the group, this will only ensure that the updated subscription is sent
on the next
+ * heartbeat request. No action will be taken if the member is in a {@link
MemberState#FATAL}
+ * state.
+ * <p/>
+ * Note that list of topics of the subscription is taken from the shared
subscription state.
+ */
+ public void onSubscriptionUpdated() {
Review Comment:
Agree, I merged them into the membership manager, and this actually goes in
the same direction we've discussed about the membership manager becoming a
first-class manager (supporting poll, for instance).So for now I integrated it
with the `ApplicationEventProcessor` already, to be able to move these 2 funcs
that I totally agree make sense in the membership manager (when tackling the
poll for triggering reconciliations, I will extend on this same direction)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
